feat: add Traditional Chinese translations for tray plugin#334
Merged
Conversation
1. Added new translation files for Traditional Chinese (zh_HK and zh_TW) 2. Translated "Remove from dock" and "Pin to dock" strings 3. Different translations provided for PluginItem and QuickPluginItem contexts 4. Supports Hong Kong and Taiwan Chinese variants with appropriate terminology feat: 添加托盘插件的繁体中文翻译 1. 新增繁体中文(香港和台湾)翻译文件 2. 翻译了"Remove from dock"和"Pin to dock"字符串 3. 为PluginItem和QuickPluginItem上下文提供不同的翻译 4. 支持香港和台湾的中文变体并使用适当的术语
deepin pr auto review代码审查结果：
改进建议：
|
Reviewer's GuideAdds two new Traditional Chinese translation files (zh_HK and zh_TW) for the tray plugin, providing localized “Remove from dock” and “Pin to dock” strings in both PluginItem and QuickPluginItem contexts. Entity relationship diagram for new translation fileserDiagram
TRAYPLUGIN_LOADER_ZH_HK ||--|| PLUGINITEM : contains
TRAYPLUGIN_LOADER_ZH_HK ||--|| QUICKPLUGINITEM : contains
TRAYPLUGIN_LOADER_ZH_TW ||--|| PLUGINITEM : contains
TRAYPLUGIN_LOADER_ZH_TW ||--|| QUICKPLUGINITEM : contains
PLUGINITEM {
string Remove_from_dock
}
QUICKPLUGINITEM {
string Remove_from_dock
string Pin_to_dock
}
Class diagram for new translation contexts in tray pluginclassDiagram
class PluginItem {
+"Remove from dock": string
}
class QuickPluginItem {
+"Remove from dock": string
+"Pin to dock": string
}
PluginItem <|-- trayplugin-loader_zh_HK
QuickPluginItem <|-- trayplugin-loader_zh_HK
PluginItem <|-- trayplugin-loader_zh_TW
QuickPluginItem <|-- trayplugin-loader_zh_TW
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- The zh_HK and zh_TW files contain identical translations—if your tooling supports it, consider consolidating into a shared zh_Hant locale to reduce duplication.
- Verify that using “駐留” versus “任務列” aligns with the rest of the UI to ensure consistent terminology across all contexts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The zh_HK and zh_TW files contain identical translations—if your tooling supports it, consider consolidating into a shared zh_Hant locale to reduce duplication.
- Verify that using “駐留” versus “任務列” aligns with the rest of the UI to ensure consistent terminology across all contexts.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BLumia
approved these changes
Jul 4, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: 添加托盘插件的繁体中文翻译
Summary by Sourcery
Add Traditional Chinese (Hong Kong and Taiwan) translations for the tray plugin by creating separate localization files and translating key UI actions.
New Features: